shell script problem

[razzera]

Hello. I am trying to make this shell script bellow work on my server wich should take the names in newacc.cvs and add them to the system. For each user the script should ask me to enter a password for the user im adding and then add them to the system, however my current solution do not work atm as when i run the script it dont stop to let me enter a password at all, it just runs past it :/ do someone know how to make this work?

Example from newacc.cvs

maria;jones
andreas;öring

Script

#!/bin/sh

if [ "$#" == "0" ]
then

cat newacc.cvs | while IFS=';'  read firstname surname;
do

    echo "user $firstname $surname har been added with the password $text"
    useradd $firstname -m
    echo  added $firstname to the system
    passwd $firstname
    cd /home/$firstname/
    maildirmake.courier Maildir
    echo Maildir Created for $firstname


done
  exit 0

[Kieren]

You should be much more careful when creating scripts like this. For instance what happens if the file contains a user that already exists on the system? In your script

useradd $firstname -m

Will throw up an error and then the rest of the script will go on to modify the users password/directories

[rojoblandino]

I am figurating you are trying to build a file in oocalc with the users information and then do it with the script.

Now you should build another one that erase them from the system.

I would do it something like this

#! /bin/bash

for item in `cat $1`;do
firstname=`echo $item| awk -F";" '{print $1}'`
surname=`echo $item| awk -F";" '{print $2}'`
ifexist=`cat /etc/passwd | grep $firstname | wc -l`
if let "ifexist==0";then
# Adding the username to the db system
useradd -c $firstname" "$surname -m $firstname
echo "Type a password for "$firstname" User"
passwd $firstname
cd /home/$firstname/
maildirmake.courier Maildir
echo "Maildir Created for "$firstname
else
echo "The user "$firstname" is already in the system"
fi
done

It just do what you are asking there are more things to watch but is a simple idea what you want.

You must run the code like this:

# bash program.sh newacc.cvs