[devils casper]

That was BIOS/GRUB compatibility problem. GRUB was installed in MBR of Vista HD and it doesn't work in a few machines.
Either install all OSes in Single Disk but if you want to install in separate HDs then unplug Windows HD before installation to avoid that problem.

[surj08]

its worth a shot to try again whats the commands to add vista and xp to grub?

[devils casper]

I assume that Linux HD is Plugged in as Primary, Windows OSes HD as Secondary/Slave. You are using Ubuntu's Boot Loader because you have installed it in the last.
Boot up Ubuntu, press Alt+F2 and type this

gksu gedit /boot/grub/menu.lst

Add this :

title Windows Boot Loader
      rootnoverify (hd1,0)
      map (hd1) (hd0)
      map (hd0) (hd1)
      chainloader +1

Save file and reboot machine. Select Windows Boot Loader option in GRUB Menu. It will invoke Vista boot loader having options to boot Vista and Windows XP.

In case it doesn't work, execute this in Ubuntu's Terminal :

sudo fdisk -l

Post output here.