[lordnothing]

okay.. i bought teh book "Teach Yourself C In 21 Days" today and have found it to be a good book to learn from.. so, here i am plodding along, typing the example programs and all of a sudden one seg faults when it comes to the 'if' statements while it's running... any of you know why such a simple program would seg fault?? here is the code so you can test it if you want.. (btw, i'm running it on a K7 (Athlon) 500 w/128mb RAM, console)

/* Demonstrates the use of if statements. */
                                                                                
#include <stdio.h>
                                                                                
int x, y;
                                                                                
int main()
{
        /* input the two values to be tested */
                                                                                
        printf("\nInput an integer value for x: ");
        scanf("%d", &x);
        printf("\nInput an integer value for y: ");
        scanf("%d", y);
                                                                                
        /* test values and print result */
                                                                                
        if (x==y)
                printf("x is equal to y\n");
                                                                                
        if (x>y)
                printf("x is greater than y\n");

        if (x<y)
                printf("x is less than y\n");
                                                                                
        return 0;
}

[jasonlambert]

             
        printf("\nInput an integer value for x: ");
        scanf("%d", &x);
        printf("\nInput an integer value for y: ");
        scanf("%d", y);

Your missing the "&" from variable y in the 2nd scanf.

always compile your code with "-Wall" , which shows these type of errors during compile time and & "-g" which includes debugging information in the binary for use in ddd / gdb.

gcc source.c -Wall -g -o executablefile

Jason

[lordnothing]

thanks.. don't knowmuch about the compiler options and such.. also shows what can happen when typing code at 3:30am...

[Joan Garnet]

It's recommendede to

fflush(stdin);

after scanf

[lordnothing]

why's that? /me is complete C noob... hence the book and ridiculous example program that does nothing useful.

[sarumont]

fflush() is a function that flushes out a stream like stdin or the file stream if you're reading a file. When scanf() takes the integer, there could be stuff hanging around in stdin. It will stay in the stream until the next function calls it. So the other scanf() would use what was left, not the new input. fflush( stdin ); fixes that.