scripting help

[slyth]

#/bin/bash
if [ test "$1" -z = "0" ]; then
   echo "usage test noargs"
   exit 1
fi

case $1 in
 one) echo "first argument";;
 *) echo $1;;
esac

Command line:
[root@localhost centos]# ./test
./test: line 2: [: too many arguments

[root@localhost centos]#

[i92guboj]

[CODE]
#/bin/bash
if [ test "$1" -z = "0" ]; then

This is redundantly redundant First, you use either "if" or "test", second, you use -z or = "0", but not both.

So, these are equivalent:

if [ -z "$foo" ]; then echo foo; fi
if [ "$foo" == "" ]; then echo foo; fi
test -z "$foo" && echo foo

EDITED (for clarification).

Note that -z and == "0" are not the same. -z is true if the string length is zero, but not if the string is equal to "0" (its length in that case would be 1 character). You could also use if [ "$#" == "0" ], since "$#" contains the number of parameters, this would be (semantically) more accurate for your purpose. However, measuring the length of the first parameter should work equally, unless someone is idiot enough to send a "" (empty string) as first parameter (and in that case, you would want the program to abort anyway).