bash scripting

[ph3ar911]

hi all. im new to scripting.

im trying to add a list of users which are all stored in a data file. so far, i can only get it to do this for the first line in the data file.

this is what i have so far.

#!/bin/sh
var=`cat /root/data`
for i in $var; do
exec adduser -s /sbin/nologin $i; password $i
done

any help would be greatly appreciated.

[ghostdog74]

put double quotes and see how it goes

for i in `cat filename`
do
  exec adduser -s /sbin/nologin "$i"; password "$i"
done

otherwise, use a while loop instead

while read -r i
do
   exec adduser -s /sbin/nologin "$i"; password "$i"
done < file

otherwise, it both did not work, show us samples

[ph3ar911]

Thanks. For some reason its still only executing it for the first line in the file.

[drl]

Hi.

exec: exec [-cl] [-a name] file [redirection ...]
Exec FILE, replacing this shell with the specified program.

-- excerpt from man bash

So you are saying, "run adduser, and don't continue with the remainder of the code in this script, exit after the first run of adduser". To fix this part of the script, just remove the exec:

...
do
   adduser -s ...

There are situations when you should use exec, but this is not one of them ... cheers, drl

[ph3ar911]

thanks heaps. that works fine now