[SOLVED] Valid Bash script?

[Mistoffeles]

I picked up a script from a hardening procedure, but it doesn't say what it is. Before I go and do something stupid, is this a valid Bash script? And is there any reason (i.e.: totally break the system) why these services should be disabled? (yes, I intend for the system not to ever print, so cups is included)

for SERVICE in \
chargen \
chargen-udp \
cups \
cups-lpd \
daytime \
daytime-udp \
echo-udp \
eklogin \
ekrb5-telnet \
finger \
gssftp \
klogin \
krb5-telnet \
kshell \
ktalk \
ntalk \
rexec \
rlogin \
rsh \
talk \
tcpmux-server \
telnet \
tftp \
time-dgram \
time-stream \
uucp;
do
if [ -e /etc/xinetd.d/$SERVICE ]; then
echo "Disabling SERVICE($SERVICE) - `ls -la /etc/xinetd.d/$SERVICE`."
chkconfig ${SERVICE} off
else
echo "OK. SERVICE doesn't exist on this system ($SERVICE)."
fi
done

Sorry for the lack of whitespace, the forum software (grr) keeps deleting it, leading tabs, leading spaces, whatever

[Rubberman]

You can keep the whitespaces if you enclose your code inside a code block. IE:

for SERVICE in \
chargen \
chargen-udp \
cups \
cups-lpd \
daytime \
daytime-udp \
echo-udp \
eklogin \
ekrb5-telnet \
finger \
gssftp \
klogin \
krb5-telnet \
kshell \
ktalk \
ntalk \
rexec \
rlogin \
rsh \
talk \
tcpmux-server \
telnet \
tftp \
time-dgram \
time-stream \
uucp;
do
if [ -e /etc/xinetd.d/$SERVICE ]; then
    echo "Disabling SERVICE($SERVICE) - `ls -la /etc/xinetd.d/$SERVICE`."
    chkconfig ${SERVICE} off
else
    echo "OK. SERVICE doesn't exist on this system ($SERVICE)."
fi
done

Anyway, without running it, it looks ok to me.

[bigtomrodney]

Just to second Rubberman, from a quick glance it looks good to me, it's simply disabling the list of services provided. The backslash is just a carriage return/escape to allow the list to be more readable.

[Mistoffeles]

Seems to have worked with no adverse effects, thanks for the help.