Bash not bahving

[zeroth404]

Problem 1: changing == to = in the if statements below will ALWAYS result in the if block not being executed. == is NOT the same as = despite all the documentation I can find.

Problem 2: the if block on the '$doit' test will NEVER be executed regardless of satisfying the conditions via the 'read' command above


packages="test";
doit="false";

if (( $# >= 2 )); then
if (( "${1:0:1}" == "y" )); then
doit="true";
fi
fi

if (( "$doit" == "false" )); then
echo "Continue?";
read ans;

if (( "${ans:0:1}" != "y" )); then
echo NO!
exit
fi
fi

echo YEAH!

[drl]

Hi.

I changed your code and added 2 debugging tools: the "set" commands near the top. I recommend that you add these two to your original script, and then compare the results to running this version.

For the issue of "==" I suggest you read the man page for bash and look for the string "==". You should be able to find it in 2 places, one for strings, and one for arithmetic comparisons.

I didn't test every combination of inputs, but it seemed to run correctly on the ones I did test:

#!/usr/bin/env bash

# @(#) s1	Demonstrate debugging.

echo
set -o nounset
set -x

packages="test";
doit="false";

if (( $# >= 2 ))
then
  if [[ "${1:0:1}" == "y" ]]
  then
    doit="true";
  fi
fi

if [[ "$doit" == "false" ]]
then
  echo "Continue?";
  read ans;

  if [[ "${ans:0:1}" != "y" ]]
  then
    echo NO!
    exit
  fi
fi

echo YEAH!

exit 0

Please note that it is easier to read code and data when it is surrounded by CODE tags.

Best wishes ... cheers, drl

[ghostdog74]

if you want to use [ to test for integers, quote your variables

if [ "$#" -gt 2 ];then
 .....
fi