[SOLVED] Help for the Noob: menu script

[maff20]

Hi all,
Im a complete novice to linux scripting, and my code is not working. Please help me, i am getting errors on lines 25, 34 and 38 when the respective options are chosen from the menu. Here is the code i have;

while :
do
clear
echo "Main - Menu"
echo "What would you like to do?..."
echo ""
echo "1. Show date and time"
echo "2. Users Logged on"
echo "3. Create a directory"
echo "4. Start text editor (joe)"
echo "5. Exit"
echo ""
echo -n "Please enter your choice (1 - 5):"
read opt
case $opt in
1) echo "";
   echo "Todays date is `date '+%d/%m/%y'`";
   echo "The current time is `date '+%H:%M'`";
   echo "";
   echo "Press [enter] to return to the menu";
read enterkey;;
2) echo "";
   echo "Please enter the username to check";
read username;
while [$(who | grep $username)!=0]
do
   echo "That user is not currently logged in";
done;
echo "";
   echo "Press [enter] to return to the menu";
read enterkey;;
3) 	echo "Please enter a name for your directory:"
  	read DIRNAME
	if [!-d "$DIRNAME" -a !-f "%DIRNAME"]
	then
	echo "Creating directory $DIRNAME"
	mkdir ~/$DIRNAME;
	elif [-d "$DIRNAME"]
	then 
	echo Directory $DIRNAME already exists
	else
	echo File %DIRNAME already exists
	fi;
	echo "Press [enter] to return to the menu";
	read enterkey;;
4) joe newfile;; 
5) echo "Goodbye $USER";
exit 1;;
*) echo "$opt is an invalid option. Please select an option between 1 and 5";
echo "Press [enter] to continue...";
read enterkey;;
esac
done

If any of you can help id be most appreciative, thanks

[gerard4143]

this line

while [$(who | grep $username)!=0]

you should have spaces after [ and before ]...like below

while [ $(who | grep $username)!=0 ]

[gerard4143]

Actually you have some problems with your script. I took a small section, choice 2, and modified it. Is this what you want?

#! /bin/sh


echo -n "Please enter the username to check->"
read username

if  who | grep $username
then
	:
else
	echo "'$username' is not currently logged in";
fi

exit 0

Note: If your going to use line numbers to identify your errors please include them in your posting...

[maff20]

Thats great gerard, i cant thank you enough - exactly what i was trying to acheive