Character Pointers

[nikhil.]

hi,

I need to creates string suffixes out of a Reference string.
for eg. suffixes of abcdefg will be

1)bcdefg
2)cdefg
3)defg
and so on...

my idea was to create an array of pointers to point to the first few characters and then use that pointer to print the rest of the string.
But when i print using the pointer i get GARBAGE values!!!!

shudn't std::cout<<ptr[w] print the string following the char it is pointing to? why do i get garbage values??

[KevinA]

Can you use library's?

why not just use substr?
cplusplus.com/reference/string/string/substr/

[Rubberman]

why do i get garbage values??

Please post your code here and we can tell you why. Usually it means that you are accessing bogus memory addresses.

[nikhil.]

// creating 5 Suffixes
int k=1;
char *ptr[5]; //i need array of pointers
while(k<6)
{
ptr[k]=refcpy+k; //refcpy is where my original string is stored
k++;
}

//printing suffixes
for(int w=1;w<=5;w++)

{
std::cout<<ptr[w]; // this step prints suffixes but with garbage values!!!
std::cout<<"\n";

}

[Rubberman]

Ok. Your indexing of the array is bogus. C/C++ use 0-based indexing, so you should do this:

// creating 5 Suffixes
// rubberman: note that it is better to use const char* type here
// since you are not modifying them.
const char* ptr[5]; //i need array of pointers
for (int k = 0; k<5; k++)
{
     ptr[k]=refcpy+k; //refcpy is where my original string is stored
}

//printing suffixes
for(int w=0;w<5;w++)
{
     std::cout<<ptr[w] << endl; // this step should print suffixes without garbage values.
}

P.S. I hope this isn't a school project - not allowed on the forums. If so, consider this a freebee.

[nikhil.]

[QUOTE=P.S. I hope this isn't a school project - not allowed on the forums. If so, consider this a freebee.[/QUOTE]

well, its a very small part of my project. Wanted to make sure i wasn't wrong conceptually!!

[Rubberman]

Some computer languages use 1-based indexing for arrays. C and its derivatives (C++, Java, et al) use 0-based indexing. Something to remember. I think that Visual Basic uses 1-based indexing, though my memory may be faulty - I haven't done any VB programming in a LONG time.

[nikhil.]

hehe i knw.. can't beleive that was my mistake!!!!

[Rubberman]

hehe i knw.. can't beleive that was my mistake!!!!

Live and learn! Good luck!

[nikhil.]

thank you!